> On Jan. 29, 2016, 9:07 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java, 
> > line 45
> > <https://reviews.apache.org/r/42964/diff/2/?file=1225903#file1225903line45>
> >
> >     Since this is a custom header perhaps we should prefix it with `X-`?

`X-` prefixes have been deprecated for some time: 
https://tools.ietf.org/html/rfc6648. I don't know that anyone's actually 
listening to that RFC, but we can be the change we want to see in the world, 
right? ;)


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117013
-----------------------------------------------------------


On Jan. 29, 2016, 8:54 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2016, 8:54 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1601
>     https://issues.apache.org/jira/browse/AURORA-1601
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add header to allow bypassing the LeaderRedirectFilter.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 
> 41b99846bff65c4d10d5d74ca8534768b0ce3fd3 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 
> 21371d951f8c6e44c40f97793d6acd26d3ca5614 
> 
> Diff: https://reviews.apache.org/r/42964/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Reply via email to