----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42985/#review117049 -----------------------------------------------------------
Fix it, then Ship it! src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java (line 87) <https://reviews.apache.org/r/42985/#comment178115> I suggest you raise the default to a very conservative level (like 1 minute) until we better understand how the newly-introduced locking affects the app. A high timeout means potentially waiting longer, but avoids issues where parts of the app because we don't handle a lock timeout. - Bill Farner On Jan. 29, 2016, 3:23 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42985/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2016, 3:23 p.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-1596 > https://issues.apache.org/jira/browse/AURORA-1596 > > > Repository: aurora > > > Description > ------- > > Add a flag to configure H2 LOCK_TIMEOUT. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java > 8b8c54a116726aa7d3400a54df6439fd368258e7 > > Diff: https://reviews.apache.org/r/42985/diff/ > > > Testing > ------- > > > Thanks, > > Zameer Manji > >
