> On Jan. 29, 2016, 3:29 p.m., Bill Farner wrote:
> > docs/committers.md, line 67
> > <https://reviews.apache.org/r/42984/diff/1/?file=1226117#file1226117line67>
> >
> >     The `[RESULT][VOTE]` part should become step 5 - successful and failed 
> > votes are closed out in the same way.
> 
> John Sirois wrote:
>     Well, when I reviewed failed vote emails in the past they both do not 
> include a vote tally and may not include the ids of the binding voters in the 
> to.
> 
> John Sirois wrote:
>     Basically there is or may be a good deal of ceremony here but from the 
> outside its not clear which bits are ceremony in the emails and which bits 
> are random.

Whoops, i thought there was no instruction for a result thread of a successful 
vote.  I see now that i overlooked it.  LGTM!

No argument about the ceremony - i'm still learning this myself.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42984/#review117046
-----------------------------------------------------------


On Jan. 29, 2016, 3:20 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42984/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2016, 3:20 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell, Maxim Khutornenko, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Hints of this protocol exist down in step 6 when a release succeeds,
> but this places the failure action in-line in the step process to make
> it more likely the reader does the right thing.
> 
> Also kill an incorrect instruction to send the successful release vote
> result email to the private@ list.
> 
>  docs/committers.md | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> 
> Diffs
> -----
> 
>   docs/committers.md a0a3cf55a25f2e97cc1f8d16e9ea549fef2fffd4 
> 
> Diff: https://reviews.apache.org/r/42984/diff/
> 
> 
> Testing
> -------
> 
> I have no clue if the instructions and provided example link are correct.
> I did find variation when reading past [RESULT][VOTE] failures; so
> guidance on what is required vs what is personal flair is appreciated.
> 
> Rendered here: 
> https://github.com/jsirois/aurora/blob/jsirois/release-docs/more-fixes/docs/committers.md
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Reply via email to