> On Jan. 29, 2016, 3:56 p.m., Aurora ReviewBot wrote:
> > Master (0eb753d) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> >                            """Stop the runner.  If it's already 
> > completed, no-op.  If it's still running, issue a kill."""
> >                            log.info('ThermosTaskRunner is shutting 
> > down.')
> >                          
> >                            if not self.forking.is_set():
> >                              raise TaskError('Failed to call 
> > TaskRunner.start.')
> >                          
> >                            log.info('Invoking runner.kill')
> >                            self.kill()
> >                          
> >                            waited = Amount(0, Time.SECONDS)
> >                            while self.is_alive and waited < timeout:
> >                              
> > self._clock.sleep(self.POLL_INTERVAL.as_(Time.SECONDS))
> >                              waited += self.POLL_INTERVAL
> >                          
> >                            if not self.is_alive and self.task_state() 
> > != TaskState.ACTIVE:
> >                              return
> >                          
> >                            log.info('Thermos task did not shut down 
> > cleanly, rebinding to kill.')
> >                            self.quitquitquit()
> >                          
> >                            while not self._monitor.finished and waited 
> > < timeout:
> >                              
> > self._clock.sleep(self.POLL_INTERVAL.as_(Time.SECONDS))
> >                              waited += self.POLL_INTERVAL
> >                          
> >                            if not self._monitor.finished:
> >                      >       raise TaskError('Task did not stop within 
> > deadline.')
> >                      E       TaskError: Task did not stop within 
> > deadline.
> >                      
> >                      
> > .pants.d/python-setup/chroots/3a746f58f5a747cd9caa30cc01558d3ddf64803e/apache/aurora/executor/thermos_task_runner.py:343:
> >  TaskError
> >                      -------------- Captured stderr call --------------
> >                      Writing log files to disk in /tmp/user/2396/tmpiA5_AW
> >                      ERROR] Could not quitquitquit runner: Cannot take 
> > control of a task in terminal state.
> >                       generated xml file: 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.executor.executor.xml
> >  
> >                       1 failed, 36 passed, 2 skipped in 121.44 
> > seconds 
> >                      
> > FAILURE
> > 
> > 
> > 23:51:01 09:23   [complete]
> >                FAILURE
> > 
> > 
> > I will refresh this build result if you post a review containing 
> > "@ReviewBot retry"

I can't reproduce this failure.  I suspect it's not related to my change.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42953/#review117062
-----------------------------------------------------------


On Jan. 29, 2016, 3:31 p.m., Benjamin Staffin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42953/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2016, 3:31 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-1577
>     https://issues.apache.org/jira/browse/AURORA-1577
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Still handles the old --read-json behavior of expecting a single job,
> but adds the ability to read files with a {"jobs": [job1, job2, ...]}
> schema like the pystachio format.
> 
> Also adds --read-json to the `aurora config load` command, as it is
> now useful there.
> 
> Json configs are now loaded in a way that is much closer to the
> pystachio one, so the config loader will no longer ignore unknown
> fields.
> 
> Fixes: AURORA-1577
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/config.py 
> 73b556266183bf17463881b87cda107d07d79d71 
>   src/main/python/apache/aurora/config/__init__.py 
> 665e2cd08d4146e652b13bb82e04680315a1eebe 
>   src/main/python/apache/aurora/config/loader.py 
> a967b9dca353f5a70c89abee5d45220a9593c01a 
>   src/test/python/apache/aurora/config/test_loader.py 
> 9789255cb0280ef0d1a83cd8c1cf8fa3581553b5 
> 
> Diff: https://reviews.apache.org/r/42953/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Staffin
> 
>

Reply via email to