> On Feb. 4, 2016, 10:37 a.m., Stephan Erb wrote: > > During this whole odyssee, have we learned a thing which is not reflected > > here? > > https://github.com/apache/aurora/blob/master/docs/thrift-deprecation.md > > > > If yes, please write it down :-) > > John Sirois wrote: > I concur, but I'm fine with the doc update coming after this. I'd like > to block RC on production bugs and bugs in docs facing users (storage > recovery docs for example), but developer docs can slide a bit imo. > > I think that doc places a wrong emphasis on dual reads - I think in fact > this is bad advice. The key is dual writes (bi-directional filling), at the > 1st encounter of any thrift struct. This is the only way to ensure sets and > maps will work as expected throughout the application and it frees the rest > of the app to read the field from the current single canonical location, > whatever that is.
I have updated AURORA-1605 to also revisit thrift deprecation instructions. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43172/#review117791 ----------------------------------------------------------- On Feb. 4, 2016, 2:14 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43172/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2016, 2:14 a.m.) > > > Review request for Aurora, John Sirois and Bill Farner. > > > Bugs: AURORA-1603 > https://issues.apache.org/jira/browse/AURORA-1603 > > > Repository: aurora > > > Description > ------- > > This change ensures we can un-revert https://reviews.apache.org/r/43104/ when > 0.12.0 ships and still have a graceful rollback from 0.13.0 to 0.12.0. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java > 27f1f33ffc782b3d2a2a9add494c04911659e217 > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java > 042f71dd8bc81d03f2759ee7f7f4b65a098d11e2 > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java > db90150b48c5b134dde6c69f70ebca82bfdd0c12 > src/main/java/org/apache/aurora/scheduler/storage/log/ThriftBackfill.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java > 54defc256ad8a261c6b56ee06ad7fdd16a26b057 > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java > 7382eca281eeab17d407ed140f16d6a633d8ad72 > > src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java > 806f50d57e44261e3a1988a3c9bb742442badde8 > > src/test/java/org/apache/aurora/scheduler/storage/log/ThriftBackfillTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/43172/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >
