-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43237/#review118058
-----------------------------------------------------------


Ship it!





src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java (line 64)
<https://reviews.apache.org/r/43237/#comment179326>

    storeTasks or createTasks? Otherwise it's confusing to see loadTasks here 
and fetchTasks in the benchmark.


- Maxim Khutornenko


On Feb. 5, 2016, 6:57 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43237/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2016, 6:57 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This adds a benchmark for the throughput of fetching tasks from both the DB 
> and InMem store.
> 
> 
> Diffs
> -----
> 
>   src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43237/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew jmh -Pbenchmarks='TaskStoreBenchmarks.*'
> 
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run        10000  thrpt    5   
> 44.395 ±  15.378  ops/s
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run        50000  thrpt    5    
> 0.184 ±   0.013  ops/s
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run       100000  thrpt    5    
> 0.077 ±   0.037  ops/s
> TaskStoreBenchmarks.MemFetchTasksBenchmark.run       10000  thrpt    5  
> 562.370 ± 768.131  ops/s
> TaskStoreBenchmarks.MemFetchTasksBenchmark.run       50000  thrpt    5   
> 81.901 ±  28.108  ops/s
> TaskStoreBenchmarks.MemFetchTasksBenchmark.run      100000  thrpt    5   
> 38.883 ±  14.443  ops/s
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to