> On Feb. 5, 2016, 9:08 p.m., John Sirois wrote: > > Can you note the technique you used for finding all last vestigaes of > > missing backfill in the testing done? > > Was this grep-provable as the last bit to fix for example?
That was mostly an oversight as we should have backfilled everything touched in api.thrift: https://reviews.apache.org/r/42811/diff/3#1 - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43262/#review118076 ----------------------------------------------------------- On Feb. 5, 2016, 9:03 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43262/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2016, 9:03 p.m.) > > > Review request for Aurora, John Sirois and Bill Farner. > > > Bugs: AURORA-1610 > https://issues.apache.org/jira/browse/AURORA-1610 > > > Repository: aurora > > > Description > ------- > > Backfilling JobConfiguration.Identity > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/log/ThriftBackfill.java > 9c88f5763d77ec0a304fdb2530ef6b6c1b0f230e > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java > 13fcf9fd3afc14cf572d4bc7de355ff698b2c222 > > src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java > 3b176db12369bc5a2a63cb0018ffca7ef8b9055d > > src/test/java/org/apache/aurora/scheduler/storage/log/ThriftBackfillTest.java > 506d5919b9db14e04b10190a5f2d2aef123ac1dc > > Diff: https://reviews.apache.org/r/43262/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >
