> On Feb. 5, 2016, 4:19 p.m., Stephan Erb wrote: > > Two minor things: > > > > * NEWS entry is missing. > > * Mesos is now calling `executorLost` (as indicated in the upgrade > > instructions). Should we bump the severity of [our log error > > message](https://github.com/apache/aurora/blob/9ed81a7db58f6a7cb308c8ac6a545705351c8c0e/src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java#L258) > > to `WARNING`? [The way Mesos is calling this > > callback](https://github.com/apache/mesos/blob/c7513a2d50a976a68a4881327a0c803c8d1b0a0e/src/sched/sched.cpp#L1057) > > tends to indicated that thermos has crashed. > > Bill Farner wrote: > +1 to both > > Joshua Cohen wrote: > I'll add a NEWS entry. The `executorLost` call is in the 0.26.x -> 0.27.x > upgrade though, so going to leave that be for now.
I updated the `executorLost` logging level as well, because... why not. - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43253/#review118021 ----------------------------------------------------------- On Feb. 9, 2016, 4:22 p.m., Joshua Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43253/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2016, 4:22 p.m.) > > > Review request for Aurora, John Sirois and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Mesos 0.26.0 release notes: > https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.26.0 > > > Diffs > ----- > > 3rdparty/python/BUILD 943ee5d9728c4c2e54c0dcdbc0db45a05b052e82 > NEWS 395c281e9b4ad83d2f5ec635fb7ec2da288afbdf > build.gradle 5b9e0152bfe3fe1f304fa839cfc4cec646819c2e > examples/vagrant/provision-dev-cluster.sh > fc8915f4ccd85f92469162db4bcfc3f1521f994b > src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java > 260a7b8e539b5d9b0a83b350536e031d1ac35f8d > > src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java > 7de8f4cebcda51953e00322caec6ad278951f6b1 > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java > cc06b85f30f6e0865a4e45606103cceedb41eaf7 > src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java > 0d41466aa791590d219721aa4e12937d7b5939a4 > src/test/java/org/apache/aurora/scheduler/mesos/TaskStatusStatsTest.java > 7e0709fefc42c1a2379bda37219fddf28cfbbb9a > > Diff: https://reviews.apache.org/r/43253/diff/ > > > Testing > ------- > > ./gradlew build -Pq > End to end tests all pass. > > > Thanks, > > Joshua Cohen > >
