-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43457/#review118783
-----------------------------------------------------------



Master (46277a1) is red with this patch.
  ./build-support/jenkins/build.sh

                           
self._clock.converge(threads=[hct.threaded_health_checker])
                           
self._clock.assert_waiting(hct.threaded_health_checker, amount=1)
                         
                           assert hct._total_latency == 0
                           assert 
hct.metrics.sample()['total_latency_secs'] == 0
                         
                           # start the health check (during health check it 
is still 0)
                           epsilon = 0.001
                           self._clock.tick(1.0 + epsilon)
                           
self._clock.converge(threads=[hct.threaded_health_checker])
                           
self._clock.assert_waiting(hct.threaded_health_checker, amount=0.5)
                           assert hct._total_latency == 0
                           assert 
hct.metrics.sample()['total_latency_secs'] == 0
                           assert hct.metrics.sample()['checks'] == 0
                         
                           # finish the health check
                           self._clock.tick(0.5 + epsilon)
                           
self._clock.converge(threads=[hct.threaded_health_checker])
                           
self._clock.assert_waiting(hct.threaded_health_checker, amount=1)  # 
interval_secs
                     >     assert hct._total_latency == 0.5
                     E     AssertionError: assert 0.5009999999999999 
== 0.5
                     E      +  where 0.5009999999999999 = 
<apache.aurora.executor.common.health_checker.HealthChecker object at 
0x7f3ce9dc6c90>._total_latency
                     
                     
src/test/python/apache/aurora/executor/common/test_health_checker.py:174: 
AssertionError
                     -------------- Captured stderr call --------------
                     [<twitter.common.testing.clock.ThreadedClock object at 
0x7f3ce9dc6510>] Time now: 0.0
                     [<twitter.common.testing.clock.ThreadedClock object at 
0x7f3ce9dc6510>] Time now: 0.0
                     [<twitter.common.testing.clock.ThreadedClock object at 
0x7f3ce9dc6510>] Time now: 1.0
                     [<twitter.common.testing.clock.ThreadedClock object at 
0x7f3ce9dc6510>] Time now: 1.001
                     [<twitter.common.testing.clock.ThreadedClock object at 
0x7f3ce9dc6510>] Time now: 1.001
                     [<twitter.common.testing.clock.ThreadedClock object at 
0x7f3ce9dc6510>] Time now: 1.501
                     [<twitter.common.testing.clock.ThreadedClock object at 
0x7f3ce9dc6510>] Time now: 1.502
                      generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
                      1 failed, 658 passed, 5 skipped, 1 warnings in 
425.37 seconds 
                     
FAILURE


00:44:32 08:53   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 11, 2016, 12:35 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43457/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2016, 12:35 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Profiling master indicated that the bottleneck was MyBatis populating 
> ResultSets and populating the resulting objects. This patch removes 
> subselects, which reduces the number of ResultSets and removes the population 
> of an object via a constructor which is slower than populating an object via 
> setters.
> 
> 
> Diffs
> -----
> 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssginedPort.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssignedTask.java
>  93722395ed9fcd22dcb12e34e648e6e410952d43 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbScheduledTask.java
>  502a1fa6fc141df498f0f09af292ce24e269731d 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
>  b1394cf44b7ddafcbc47bb1968306d0b33293380 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml 
> ea469cce31544221c34ae05a1c65f71271985655 
> 
> Diff: https://reviews.apache.org/r/43457/diff/
> 
> 
> Testing
> -------
> 
> Master:
> Benchmark                                      (numTasks)   Mode  Cnt   Score 
>    Error  Units
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run       10000  thrpt    5  44.052 
> ± 14.689  ops/s
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run       50000  thrpt    5   0.179 
> ±  0.052  ops/s
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run      100000  thrpt    5   0.087 
> ±  0.022  ops/s
> 
> This Patch:
> Benchmark                                      (numTasks)   Mode  Cnt   Score 
>   Error  Units
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run       10000  thrpt    5  51.531 
> ± 7.236  ops/s
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run       50000  thrpt    5   7.370 
> ± 1.320  ops/s
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run      100000  thrpt    5   2.143 
> ± 1.234  ops/s
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to