-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43457/
-----------------------------------------------------------

(Updated Feb. 11, 2016, 12:03 p.m.)


Review request for Aurora, John Sirois and Maxim Khutornenko.


Changes
-------

Use in place sort.


Repository: aurora


Description
-------

Profiling master indicated that the bottleneck was MyBatis populating 
ResultSets and populating the resulting objects. This patch removes subselects, 
which reduces the number of ResultSets and removes the population of an object 
via a constructor which is slower than populating an object via setters.


Diffs (updated)
-----

  
src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssginedPort.java 
PRE-CREATION 
  
src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssignedTask.java 
93722395ed9fcd22dcb12e34e648e6e410952d43 
  
src/main/java/org/apache/aurora/scheduler/storage/db/views/DbScheduledTask.java 
502a1fa6fc141df498f0f09af292ce24e269731d 
  
src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml 
b1394cf44b7ddafcbc47bb1968306d0b33293380 
  src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml 
ea469cce31544221c34ae05a1c65f71271985655 

Diff: https://reviews.apache.org/r/43457/diff/


Testing
-------

Master:
Benchmark                                      (numTasks)   Mode  Cnt   Score   
 Error  Units
TaskStoreBenchmarks.DBFetchTasksBenchmark.run       10000  thrpt    5  44.052 ± 
14.689  ops/s
TaskStoreBenchmarks.DBFetchTasksBenchmark.run       50000  thrpt    5   0.179 ± 
 0.052  ops/s
TaskStoreBenchmarks.DBFetchTasksBenchmark.run      100000  thrpt    5   0.087 ± 
 0.022  ops/s

This Patch:
Benchmark                                      (numTasks)   Mode  Cnt   Score   
Error  Units
TaskStoreBenchmarks.DBFetchTasksBenchmark.run       10000  thrpt    5  51.531 ± 
7.236  ops/s
TaskStoreBenchmarks.DBFetchTasksBenchmark.run       50000  thrpt    5   7.370 ± 
1.320  ops/s
TaskStoreBenchmarks.DBFetchTasksBenchmark.run      100000  thrpt    5   2.143 ± 
1.234  ops/s


Thanks,

Zameer Manji

Reply via email to