-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43567/
-----------------------------------------------------------

(Updated Feb. 14, 2016, 10:46 p.m.)


Review request for Aurora, John Sirois and Zameer Manji.


Changes
-------

Clarifications proposed by Bill.


Repository: aurora


Description
-------

Closing Deflater/Inflater streams explicitly frees their native memory 
instantly. Otherwise, the memory will only be freed once the object finalizer 
runs.

I got the idea from this article 
http://www.evanjones.ca/java-native-leak-bug.html. Unfortunately, we cannot use 
the Java close-with-resource feature, as `TTransport` in our current Thrift 
version does not implement `Closable`.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 
6b65c0f6cb60b98ff352c4c5d5fed38d52b4b062 

Diff: https://reviews.apache.org/r/43567/diff/


Testing
-------

./gradlew -Pq build


Thanks,

Stephan Erb

Reply via email to