-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42656/#review119328
-----------------------------------------------------------


Fix it, then Ship it!




I ran some tests. I have dropped the open/close handling from `flush` and then:

* run the Aurora client tests
* run our internal test suite for our client-wrapper
* set up a long lasting client connection to the scheduler and then did a 
failover by stopping the current leading scheduler.

I did not notice any problems. I believe this change is therefore good to go.

Disclaimer: If there was a performance improvement, it did not surface in our 
tests.


src/main/python/apache/aurora/common/transport.py (line 114)
<https://reviews.apache.org/r/42656/#comment180646>

    I believe this whole open/close handling can be dropped from `flush`. I did 
not run into problems even when running with `assert self.isOpen()`


- Stephan Erb


On Jan. 22, 2016, 8:29 p.m., Kunal Thakar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42656/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 8:29 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> As an API consumer, I want the API client to reuse open connections and not 
> create a new one for every query.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/common/transport.py 
> 909021ac203185862267d4359d332fc169a06b7e 
>   src/test/python/apache/aurora/common/test_transport.py 
> 1f589a9ae08e1f13be34ad6002ceb11a43fdeb5f 
> 
> Diff: https://reviews.apache.org/r/42656/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest src/test/python::
> 
> 
> Thanks,
> 
> Kunal Thakar
> 
>

Reply via email to