-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43669/
-----------------------------------------------------------

(Updated Feb. 18, 2016, 8:44 a.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
-------

Addressed Maxim's review comments.


Repository: aurora


Description
-------

AURORA-1616: [part 1] refactor tier management initialization to make it 
pluggable in tests. Also, renamed tiers-example.json to tiers.json.


Diffs (updated)
-----

  docs/deploying-aurora-scheduler.md 5f89ca9d3bc5672ded954891a5fca269bd9608b3 
  examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
53db93cef7f854885439c0d946a38ee1e07c8069 
  examples/vagrant/upstart/aurora-scheduler.conf 
70e56b02130b7f71e2278f53b7e9f6c50c89949c 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
ddc0d0500b8788bc2c9dd67abb62a412465488b4 
  src/main/java/org/apache/aurora/scheduler/TierManager.java 
7367df4a030a3698518c9059aebcafc63c88e920 
  src/main/java/org/apache/aurora/scheduler/TierModule.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
cd9cb09a889984d9cb9d63b890093a075647dcbf 
  src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java 
9dd05690c1abb068b57259e20415c10ad1697a97 
  src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
350b90b7333b5e8f195909eeca915ad91d7307fe 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
39916f5ceffec788046a4cc4c4e33aed4d57513b 
  src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 
4716b66307bad16ecf29ec977e033e31f090fc9d 
  src/test/resources/org/apache/aurora/scheduler/tiers-example.json  

Diff: https://reviews.apache.org/r/43669/diff/


Testing
-------

* Ensure no references to tiers-example.json
```
$ fgrep tiers-example -r ./* || echo Not found   # No remaining references to 
tiers-example.json
Not found
```

* Double check references to tiers.json
```
$ ./gradlew clean && fgrep tiers.json -r ./*
...
BUILD SUCCESSFUL

Total time: 8.811 secs
./docs/deploying-aurora-scheduler.md:Example [tier configuration 
file](../src/test/resources/org/apache/aurora/scheduler/tiers.json).
./examples/vagrant/upstart/aurora-scheduler-kerberos.conf:  
-tier_config=/home/vagrant/aurora/src/test/resources/org/apache/aurora/scheduler/tiers.json
./examples/vagrant/upstart/aurora-scheduler.conf:  
-tier_config=/home/vagrant/aurora/src/test/resources/org/apache/aurora/scheduler/tiers.json
 \
./src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java:  
          + ResourceUtils.CLASSPATH_PREFIX + 
"org/apache/aurora/scheduler/tiers.json")
```

* Unit tests
```
$ ./gradlew clean test
...
BUILD SUCCESSFUL

Total time: 2 mins 40.529 secs
```

* End-to-end tests
```
$ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
...
*** OK (All tests passed) ***
```


Thanks,

Amol Deshmukh

Reply via email to