> On March 2, 2016, 11:15 a.m., Aurora ReviewBot wrote: > > Master (8f98e6e) is red with this patch. > > ./build-support/jenkins/build.sh > > > > [1m self._clock.tick(0.5 + epsilon)[0m > > [1m > > self._clock.converge(threads=[hct.threaded_health_checker])[0m > > [1m > > self._clock.assert_waiting(hct.threaded_health_checker, amount=1) # > > interval_secs[0m > > [1m assert hct._total_latency == 0.5[0m > > [1m assert > > hct.metrics.sample()['total_latency_secs'] == 0.5[0m > > [1m assert hct.metrics.sample()['checks'] == > > 1[0m > > [1m [0m > > [1m # tick again[0m > > [1m self._clock.tick(1.0 + epsilon)[0m > > [1m > > self._clock.converge(threads=[hct.threaded_health_checker])[0m > > [1m self._clock.tick(0.5 + epsilon)[0m > > [1m > > self._clock.converge(threads=[hct.threaded_health_checker])[0m > > [1m > > self._clock.assert_waiting(hct.threaded_health_checker, amount=1) # > > interval_secs[0m > > [1m> assert hct._total_latency == 1.0[0m > > [1m[31mE AssertionError: assert 1.001 == 1.0[0m > > [1m[31mE + where 1.001 = > > <apache.aurora.executor.common.health_checker.HealthChecker object at > > 0x7faff1015990>._total_latency[0m > > > > > > src/test/python/apache/aurora/executor/common/test_health_checker.py:184: > > AssertionError > > -------------- Captured stderr call -------------- > > [<twitter.common.testing.clock.ThreadedClock object at > > 0x7faff1015fd0>] Time now: 0.0 > > [<twitter.common.testing.clock.ThreadedClock object at > > 0x7faff1015fd0>] Time now: 0.0 > > [<twitter.common.testing.clock.ThreadedClock object at > > 0x7faff1015fd0>] Time now: 1.0 > > [<twitter.common.testing.clock.ThreadedClock object at > > 0x7faff1015fd0>] Time now: 1.001 > > [<twitter.common.testing.clock.ThreadedClock object at > > 0x7faff1015fd0>] Time now: 1.001 > > [<twitter.common.testing.clock.ThreadedClock object at > > 0x7faff1015fd0>] Time now: 1.501 > > [<twitter.common.testing.clock.ThreadedClock object at > > 0x7faff1015fd0>] Time now: 1.502 > > [<twitter.common.testing.clock.ThreadedClock object at > > 0x7faff1015fd0>] Time now: 1.502 > > [<twitter.common.testing.clock.ThreadedClock object at > > 0x7faff1015fd0>] Time now: 2.502 > > [<twitter.common.testing.clock.ThreadedClock object at > > 0x7faff1015fd0>] Time now: 2.503 > > [<twitter.common.testing.clock.ThreadedClock object at > > 0x7faff1015fd0>] Time now: 2.503 > > [<twitter.common.testing.clock.ThreadedClock object at > > 0x7faff1015fd0>] Time now: 3.003 > > [<twitter.common.testing.clock.ThreadedClock object at > > 0x7faff1015fd0>] Time now: 3.004 > > generated xml file: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml > > > > [1m[31m 1 failed, 660 passed, 5 skipped, 1 warnings > > in 412.03 seconds [0m > > > > FAILURE > > > > > > 19:08:49 08:02 [complete][31m > > FAILURE[0m > > > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry"
@ReviewBot retry - Amol ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43925/#review121694 ----------------------------------------------------------- On March 2, 2016, 10:53 a.m., Amol Deshmukh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43925/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 10:53 a.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Repository: aurora > > > Description > ------- > > AURORA-1616: [part 2] make tier_config mandatory argument when starting up > the scheduler. > > > Diffs > ----- > > NEWS b84a94550f93691eba0220afedb2bb4d5e00e6bd > docs/deploying-aurora-scheduler.md 883e0f3df9c2572e7cf3e866532306d83db91adb > examples/vagrant/upstart/aurora-scheduler-kerberos.conf > d57ef371cd423c55bd80bb0b0803cfaf7a261c74 > examples/vagrant/upstart/aurora-scheduler.conf > 54fcde6889a8c08123eb73a6ea574d3dfb2e1d66 > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java > 45ab76b9331a79699979c6386c93bbc763f64e2e > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java > dc1ef82bce9e8e243974f8b97165f4417d870a7e > src/main/java/org/apache/aurora/scheduler/TierManager.java > fce6e51548b23b7bc3e33468c2b3a9627a68debd > src/main/java/org/apache/aurora/scheduler/TierModule.java > b5f065ec433b4df50a5c1ca7ef87d51292816db6 > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > 4c64a1c4bd8596a528f6dabd6f9a794348ded7d8 > src/test/java/org/apache/aurora/scheduler/SchedulerModuleTest.java > aa6e0350caa6ebe79c46e28e8d7fd7fd8d6c63d4 > src/test/java/org/apache/aurora/scheduler/TierManagerTest.java > 4da829f7b3aad18b9ed3a390eaa89afcb2f3cd29 > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java > 7ee31fd4a59014e97a36e30b5a6b66f54114ef62 > src/test/resources/org/apache/aurora/scheduler/tiers.json > 21407738fafc9bc5e6ce7888b4b9c32b2f005bca > > Diff: https://reviews.apache.org/r/43925/diff/ > > > Testing > ------- > > # Java build with checkstyle: > ``` > $ ./gradlew build -Pq > ... > BUILD SUCCESSFUL > > Total time: 3 mins 44.365 secs > ``` > > # End-to-end tests: > ``` > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ... > *** OK (All tests passed) *** > > ``` > > # Ensure affected benchmarks run: > ``` > $ ./gradlew -q jmh -Pbenchmarks='S.*Benchmark.?' > ... > Benchmark report generated: file:///.../aurora/dist/reports/jmh/human.txt > > $ ls -1 dist/reports/jmh/human.txt > dist/reports/jmh/human.txt > ... > > ``` > > # Python client tests: > ``` > ./pants test.pytest --no-fast src/test/python/apache/aurora:: > ... > SUCCESS > ``` > > > Thanks, > > Amol Deshmukh > >
