-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44471/#review122397
-----------------------------------------------------------
Master (a91a759) is red with this patch.
./build-support/jenkins/build.sh
[1m
self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m
self._clock.assert_waiting(hct.threaded_health_checker, amount=1)[0m
[1m [0m
[1m assert hct._total_latency == 0[0m
[1m assert
hct.metrics.sample()['total_latency_secs'] == 0[0m
[1m [0m
[1m # start the health check (during health check it
is still 0)[0m
[1m epsilon = 0.001[0m
[1m self._clock.tick(1.0 + epsilon)[0m
[1m
self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m
self._clock.assert_waiting(hct.threaded_health_checker, amount=0.5)[0m
[1m assert hct._total_latency == 0[0m
[1m assert
hct.metrics.sample()['total_latency_secs'] == 0[0m
[1m assert hct.metrics.sample()['checks'] == 0[0m
[1m [0m
[1m # finish the health check[0m
[1m self._clock.tick(0.5 + epsilon)[0m
[1m
self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m
self._clock.assert_waiting(hct.threaded_health_checker, amount=1) #
interval_secs[0m
[1m> assert hct._total_latency == 0.5[0m
[1m[31mE AssertionError: assert 0.5019999999999998
== 0.5[0m
[1m[31mE + where 0.5019999999999998 =
<apache.aurora.executor.common.health_checker.HealthChecker object at
0x7f7eb5f83810>._total_latency[0m
src/test/python/apache/aurora/executor/common/test_health_checker.py:174:
AssertionError
-------------- Captured stderr call --------------
[<twitter.common.testing.clock.ThreadedClock object at
0x7f7eb5f83a90>] Time now: 0.0
[<twitter.common.testing.clock.ThreadedClock object at
0x7f7eb5f83a90>] Time now: 0.0
[<twitter.common.testing.clock.ThreadedClock object at
0x7f7eb5f83a90>] Time now: 1.0
[<twitter.common.testing.clock.ThreadedClock object at
0x7f7eb5f83a90>] Time now: 1.001
[<twitter.common.testing.clock.ThreadedClock object at
0x7f7eb5f83a90>] Time now: 1.001
[<twitter.common.testing.clock.ThreadedClock object at
0x7f7eb5f83a90>] Time now: 1.5
[<twitter.common.testing.clock.ThreadedClock object at
0x7f7eb5f83a90>] Time now: 1.502
generated xml file:
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 1 failed, 660 passed, 5 skipped, 1 warnings in
423.17 seconds [0m
FAILURE
22:53:08 08:14 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On March 7, 2016, 10:22 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44471/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 10:22 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1627
> https://issues.apache.org/jira/browse/AURORA-1627
>
>
> Repository: aurora
>
>
> Description
> -------
>
> H2 DB is now `script`ed into a dedicated `dbScript` field in `Snapshot`
> thrift struct to speed up recovery under H2 MVStore.
>
> There was extra care needed to ensure task stores are functioning properly
> when they are toggled between in-memory and DB mode. Tried to document as
> much as possible. Let me know if something is still unclear. The existing
> thrift snapshot fields will be supported until all stores are fully migrated
> to H2 and removed subsequently along with in-memory store code.
>
> `SnapshotStoreImplTest` got rewritten into `SnapshotStoreImplIT` to fully
> test `TaskStore` migration matrix.
>
> Also, moved checkstyle suppressions into annotations for more precise control.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/storage.thrift
> 6dc46147bb0703e83a210a81ee24081183389a89
> config/checkstyle/checkstyle.xml 2074beb66ca19eb2da3d444bc64e583409e30ead
> config/checkstyle/suppressions.xml 50a53e0d96cb365b2182b78769c1749b7e3558a9
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java
> 60b66e85f83edd3c18c97e3938816cb875249d4e
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java
> 5124d17c9bc755e33a3e97b914caed34b77cdb94
>
> src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java
> 46b3d104931f175314902ccd39b81c4b6d67d4f3
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java
> 6d8fa11d0aed841388e1e87fc0acdaf6b8f42d06
> src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java
> cca92dd6e9e52f9e38394c4c688ab4897eb8e23f
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java
> ed63a7471d654dcefd2ff24e2e462974883541f2
>
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java
> db90150b48c5b134dde6c69f70ebca82bfdd0c12
>
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java
> 2f07afb73f6e585a6b43be68134e2beecac83d31
> src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java
> 172dd206d09f131807cb33fe841ca6ebc8198a14
>
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java
> PRE-CREATION
>
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
> 44078675286dec908da7a404ae8fce7c495a7019
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 75130a315573dbb9eff1a9b1c5408df27623cf54
>
> Diff: https://reviews.apache.org/r/44471/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
