----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44486/#review122537 -----------------------------------------------------------
Fix it, then Ship it! LGTM - thanks for the doc additions. Zameer will take this review home. NEWS (line 17) <https://reviews.apache.org/r/44486/#comment184587> This belongs in the `New/updated` section above and it's probably worth linking the new docs on github. The 0.12.0 entry below starting with `- Added support for jobs to specify arbitrary ZooKeeper paths...` is a good example. docs/configuration-reference.md (line 453) <https://reviews.apache.org/r/44486/#comment184588> s/look/looks/ and perhaps language more closely aligned with environment variables - perhaps something like "... will have the `HTTP_PORT` variable exported in its environment." - John Sirois On March 7, 2016, 7:10 p.m., Dmitriy Shirchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44486/ > ----------------------------------------------------------- > > (Updated March 7, 2016, 7:10 p.m.) > > > Review request for Aurora, John Sirois, Bill Farner, and Zameer Manji. > > > Bugs: AURORA-1622 > https://issues.apache.org/jira/browse/AURORA-1622 > > > Repository: aurora > > > Description > ------- > > Exposing ports to shell health checkers > > > Diffs > ----- > > NEWS b84a94550f93691eba0220afedb2bb4d5e00e6bd > docs/configuration-reference.md 10702ff4e700b6da7bdd7fd036de442be1eba45c > src/main/python/apache/aurora/common/health_check/shell.py > 890bf0c5d50d0022c044a37191a2e3145cc6340f > src/main/python/apache/aurora/executor/common/health_checker.py > 303972778baa04e9d7dd47fb208fe1427e779976 > src/test/python/apache/aurora/common/health_check/test_shell.py > 84f717fbf724c11863b4980fd2740dc23fe1404e > src/test/python/apache/aurora/executor/common/test_health_checker.py > 9bebce8f5a26662f58075d7ce881a8bdacb2fe46 > > Diff: https://reviews.apache.org/r/44486/diff/ > > > Testing > ------- > > Unit and end to end test. > > > Thanks, > > Dmitriy Shirchenko > >
