----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44486/#review122943 -----------------------------------------------------------
Fix it, then Ship it! Modulo a missing test, this LGTM. I will not commit this patch after the missing test is added as I think Bill and John should review the changes again. src/test/python/apache/aurora/executor/common/test_health_checker.py (line 269) <https://reviews.apache.org/r/44486/#comment185047> Can you add a test that checks interpolation is done? Like pass in assignedPorts and then check in `execconfig_data['health_check_config'['health_checker']['shell']['shell_command']` that the interpolation was done? - Zameer Manji On March 8, 2016, 9:34 p.m., Dmitriy Shirchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44486/ > ----------------------------------------------------------- > > (Updated March 8, 2016, 9:34 p.m.) > > > Review request for Aurora, John Sirois, Bill Farner, and Zameer Manji. > > > Bugs: AURORA-1622 > https://issues.apache.org/jira/browse/AURORA-1622 > > > Repository: aurora > > > Description > ------- > > Exposing DSL defined variables to shell health checkers > > > Diffs > ----- > > src/main/python/apache/aurora/common/health_check/shell.py > 890bf0c5d50d0022c044a37191a2e3145cc6340f > src/main/python/apache/aurora/executor/common/health_checker.py > 303972778baa04e9d7dd47fb208fe1427e779976 > src/test/python/apache/aurora/common/health_check/test_shell.py > 84f717fbf724c11863b4980fd2740dc23fe1404e > src/test/python/apache/aurora/executor/common/test_health_checker.py > 9bebce8f5a26662f58075d7ce881a8bdacb2fe46 > > Diff: https://reviews.apache.org/r/44486/diff/ > > > Testing > ------- > > Unit and end to end test. > > > Thanks, > > Dmitriy Shirchenko > >
