> On March 10, 2016, 10:27 p.m., Stephan Erb wrote:
> > +1 for re-raising.

Thanks for confirming. Will update.


> On March 10, 2016, 10:27 p.m., Stephan Erb wrote:
> > src/main/python/apache/thermos/core/process.py, line 151
> > <https://reviews.apache.org/r/44680/diff/1/?file=1294932#file1294932line151>
> >
> >     This means we would log the error as debug. 
> >     
> >     It has always bugged me that thermos logging was set to debug by 
> > default. Now I know why :-). Unfortunate

Yeah, I agree that it's unfortunate (also unfortunate: we don't get meaningful 
line numbers from log entries either because of this indirection) but I didn't 
want to shave that yak as part of this change ;).


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44680/#review123014
-----------------------------------------------------------


On March 10, 2016, 9:59 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44680/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 9:59 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Log exceptions raised when thermos running attempts to execute a process.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/core/process.py 
> c343b2d1f3efc39ea8c445c93a9ac73a2bed3653 
> 
> Diff: https://reviews.apache.org/r/44680/diff/
> 
> 
> Testing
> -------
> 
> ./pants test src/test/python/apache/thermos/core/
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Reply via email to