Re: Review Request 44680: Log exceptions raised when thermos running attempts to execute a process.

[Aurora ReviewBot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44680/#review123023
-----------------------------------------------------------



Master (72bf8db) is red with this patch.
  ./build-support/jenkins/build.sh

                           
self._clock.converge(threads=[hct.threaded_health_checker])
                           
self._clock.assert_waiting(hct.threaded_health_checker, amount=1)
                         
                           assert hct._total_latency == 0
                           assert 
hct.metrics.sample()['total_latency_secs'] == 0
                         
                           # start the health check (during health check it 
is still 0)
                           epsilon = 0.001
                           self._clock.tick(1.0 + epsilon)
                           
self._clock.converge(threads=[hct.threaded_health_checker])
                           
self._clock.assert_waiting(hct.threaded_health_checker, amount=0.5)
                           assert hct._total_latency == 0
                           assert 
hct.metrics.sample()['total_latency_secs'] == 0
                           assert hct.metrics.sample()['checks'] == 0
                         
                           # finish the health check
                           self._clock.tick(0.5 + epsilon)
                           
self._clock.converge(threads=[hct.threaded_health_checker])
                           
self._clock.assert_waiting(hct.threaded_health_checker, amount=1)  # 
interval_secs
                     >     assert hct._total_latency == 0.5
                     E     AssertionError: assert 0.5009999999999999 
== 0.5
                     E      +  where 0.5009999999999999 = 
<apache.aurora.executor.common.health_checker.HealthChecker object at 
0x7fbe7454ea50>._total_latency
                     
                     
src/test/python/apache/aurora/executor/common/test_health_checker.py:174: 
AssertionError
                     -------------- Captured stderr call --------------
                     [<twitter.common.testing.clock.ThreadedClock object at 
0x7fbe7454ecd0>] Time now: 0.0
                     [<twitter.common.testing.clock.ThreadedClock object at 
0x7fbe7454ecd0>] Time now: 0.0
                     [<twitter.common.testing.clock.ThreadedClock object at 
0x7fbe7454ecd0>] Time now: 1.0
                     [<twitter.common.testing.clock.ThreadedClock object at 
0x7fbe7454ecd0>] Time now: 1.001
                     [<twitter.common.testing.clock.ThreadedClock object at 
0x7fbe7454ecd0>] Time now: 1.001
                     [<twitter.common.testing.clock.ThreadedClock object at 
0x7fbe7454ecd0>] Time now: 1.501
                     [<twitter.common.testing.clock.ThreadedClock object at 
0x7fbe7454ecd0>] Time now: 1.502
                      generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
                      1 failed, 661 passed, 5 skipped, 1 warnings in 
406.83 seconds 
                     
FAILURE


22:53:26 07:55   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 10, 2016, 10:36 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44680/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 10:36 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Log exceptions raised when thermos running attempts to execute a process.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/core/process.py 
> c343b2d1f3efc39ea8c445c93a9ac73a2bed3653 
> 
> Diff: https://reviews.apache.org/r/44680/diff/
> 
> 
> Testing
> -------
> 
> ./pants test src/test/python/apache/thermos/core/
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>