> On March 10, 2016, 11:04 p.m., Stephan Erb wrote:
> > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py, line 95
> > <https://reviews.apache.org/r/44532/diff/1/?file=1292348#file1292348line95>
> >
> >     Specifying the command here feels kind of weird. All other options  we 
> > have take the value directly.
> 
> Kunal Thakar wrote:
>     Executor arguments are set in stone after starting the scheduler as they 
> are passed to the scheduler through -thermos_executor_flags, so we have to do 
> it this way.

Another way to do it would be if you use a wrapper script to launch your 
Thermos executor. If necessary, you can copy this into the sandbox using the 
`-thermos_executor_resources` flag. 

Personally, I would perfer such a solution:

* It can be used for all options.
* Thermos does not need to handle the case if the command fails. It is up to 
the operator writing the wrapper script to handle that case.


- Stephan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/#review123011
-----------------------------------------------------------


On March 8, 2016, 11:33 p.m., Kunal Thakar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44532/
> -----------------------------------------------------------
> 
> (Updated March 8, 2016, 11:33 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Allow overriding hostname before announcing
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f82858c528808d2a9e77bb56f16e897cfb5bbe73 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 34e36e0a59093468a8934f58bacb68512949347c 
> 
> Diff: https://reviews.apache.org/r/44532/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kunal Thakar
> 
>

Reply via email to