----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44799/#review123482 -----------------------------------------------------------
Ship it! Ship It! - Bill Farner On March 14, 2016, 11:53 a.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44799/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 11:53 a.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora-packaging > > > Description > ------- > > This adjusts to fallout from https://reviews.apache.org/r/43936/ to get > the centos-7 builder working again and improves the test docs to include > both locally built rpm and released (or release candidate) rpm testing. > > This change also imporves the `release-candidate` script to be > idempotent and handle missing binaries (ie: when only using a subset of > builders). > > build-support/release/release-candidate | 33 > +++++++++++++++++++++------------ > specs/rpm/Makefile | 5 ++--- > specs/rpm/aurora.spec | 2 +- > test/rpm/centos-7/README.md | 24 +++++++++++++++++++++--- > 4 files changed, 45 insertions(+), 19 deletions(-) > > > Diffs > ----- > > build-support/release/release-candidate > c21a0107043c76137daace8823dd28ac3c46957d > specs/rpm/Makefile 0fa215854df9678adf7f9a1209dfca1cc4db8ce9 > specs/rpm/aurora.spec 20a6d349eb7cd6c801ddc7b149dd656f4a517cd1 > test/rpm/centos-7/README.md 6a6e419eae0b91608450d932139e515ff47c8445 > > Diff: https://reviews.apache.org/r/44799/diff/ > > > Testing > ------- > > CentOS 7 test doc fixes rendered here: > https://github.com/jsirois/aurora-packaging/tree/0.12.x/test/rpm/centos-7 > > I exercised the `Makefile` and `aurora.spec` fixes to build a new batch of > rpms and then used the improved `release-candidate` script to create the rpm > `upload.tar` and update the 0.12.0 RC bintray repo here: > https://bintray.com/john-sirois/aurora/centos-7/0.12.0 > > > Thanks, > > John Sirois > >
