-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44827/#review123590
-----------------------------------------------------------


Ship it!




Ship It!

- Zameer Manji


On March 14, 2016, 7:10 p.m., Dmitriy Shirchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44827/
> -----------------------------------------------------------
> 
> (Updated March 14, 2016, 7:10 p.m.)
> 
> 
> Review request for Aurora, John Sirois, Bill Farner, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fixing bug where you could not pass in shell command into health checker with 
> environment variables. When environment variable assignement was passed in, 
> only that part would get executed and 0 would always get returned.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/common/health_check/shell.py 
> bf63d936b3044dfa97a787938b643a52497f2d79 
>   src/test/python/apache/aurora/common/health_check/test_shell.py 
> 8d3a3e4e259e1ff699854aeb2434ac21f38e49ea 
> 
> Diff: https://reviews.apache.org/r/44827/diff/
> 
> 
> Testing
> -------
> 
> Unit tests + end_to_end test.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Reply via email to