-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/#review123775
-----------------------------------------------------------


Fix it, then Ship it!




Patch looks good, thanks for your patience! Minor nitpick below.


src/test/python/apache/aurora/executor/common/test_announcer.py (line 341)
<https://reviews.apache.org/r/44532/#comment186029>

    Those asserts a risky. If you have a typo like `assert_any_callz()` your 
test will pass. 
    
    Could you try to write that one as an explicit assertion using `assert`? 
For example, this could be done via 
https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.mock_calls


- Stephan Erb


On March 15, 2016, 7:31 p.m., Kunal Thakar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44532/
> -----------------------------------------------------------
> 
> (Updated March 15, 2016, 7:31 p.m.)
> 
> 
> Review request for Aurora, John Sirois, Stephan Erb, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Allow overriding hostname before announcing 
> (https://issues.apache.org/jira/browse/AURORA-1611)
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f82858c528808d2a9e77bb56f16e897cfb5bbe73 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 34e36e0a59093468a8934f58bacb68512949347c 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> f4032c7302f4733ab5670322b1905102c200f1c9 
> 
> Diff: https://reviews.apache.org/r/44532/diff/
> 
> 
> Testing
> -------
> 
> Tested on vagrant with a wrapper for the executor
> 
> 
> Thanks,
> 
> Kunal Thakar
> 
>

Reply via email to