-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/#review124244
-----------------------------------------------------------




docs/configuration-reference.md (line 472)
<https://reviews.apache.org/r/44532/#comment186698>

    That sounds a little bit like "ip" is a valid value. Using `<host ip>` 
might make this more clear.


- Stephan Erb


On March 18, 2016, 7:18 p.m., Kunal Thakar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44532/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 7:18 p.m.)
> 
> 
> Review request for Aurora, John Sirois, Stephan Erb, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Allow overriding hostname before announcing 
> (https://issues.apache.org/jira/browse/AURORA-1611)
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 42bb340c492f25286c8c785885132abcbe455296 
>   docs/configuration-reference.md e043c4886c6d0fd96646f4687865d1c715cd1c58 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f82858c528808d2a9e77bb56f16e897cfb5bbe73 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 34e36e0a59093468a8934f58bacb68512949347c 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> f4032c7302f4733ab5670322b1905102c200f1c9 
> 
> Diff: https://reviews.apache.org/r/44532/diff/
> 
> 
> Testing
> -------
> 
> Tested on vagrant with a wrapper for the executor
> 
> 
> Thanks,
> 
> Kunal Thakar
> 
>

Reply via email to