> On March 15, 2016, 9:53 p.m., John Sirois wrote:
> > .gitignore, line 1
> > <https://reviews.apache.org/r/44871/diff/1/?file=1300417#file1300417line1>
> >
> >     Not related, but noticing this is a lie iiuc.  Should be 'Use /dist/ to 
> > ignore dist in project root.' (reference 'PATTERN FORMAT' section here: 
> > https://www.kernel.org/pub/software/scm/git/docs/gitignore.html).

Dropped the comment, i don't think it adds much and as you note - is incorrect.


> On March 15, 2016, 9:53 p.m., John Sirois wrote:
> > examples/vagrant/provision-dev-cluster.sh, line 125
> > <https://reviews.apache.org/r/44871/diff/1/?file=1300422#file1300422line125>
> >
> >     Is this `/home/vagrant/aurora`?  As things stand almost all paths - 
> > save for `pushd aurora` in the `prepare_extras` function - are absolute; so 
> > this relative path reads risky / uncertain.

Good point, changed to `/home/vagrant/aurora`.  This was relying on the working 
dir and `update-sources` script to line up, which indeed seems risky.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44871/#review123815
-----------------------------------------------------------


On March 15, 2016, 4:59 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44871/
> -----------------------------------------------------------
> 
> (Updated March 15, 2016, 4:59 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Relevant docs on packer can be found here: https://www.packer.io/docs/
> 
> To support this, i have created the [`apache-aurora` 
> org](https://atlas.hashicorp.com/apache-aurora).  If we move forward with 
> this patch, i will be looking to add other committers to the org and improve 
> the bus factor.
> 
> 
> Diffs
> -----
> 
>   .gitignore 1af09a251b3f76c13813033d32aa7efba9aef304 
>   Vagrantfile 2d6c2ae598e80035840f7e517e161be266b581dd 
>   build-support/packer/README.md PRE-CREATION 
>   build-support/packer/aurora.json PRE-CREATION 
>   build-support/packer/build.sh PRE-CREATION 
>   examples/vagrant/provision-dev-cluster.sh 
> df33a30c1dcc0ea832899c849be05fe9deb47433 
> 
> Diff: https://reviews.apache.org/r/44871/diff/
> 
> 
> Testing
> -------
> 
> I can run `vagrant up`.  Currently looking into a possible configuration 
> issue in end-to-end tests, to be corrected before submitting.
> 
> Reviewers - you can do this as well by applying the patch.  You will observe 
> a long fetch on the first run (much like you would with the current repo if 
> you wiped your local vagrant boxes).  However, subsequent `vagrant destroy`, 
> `vagrant up` cycles should be relatively fast, about 1m30s for me.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to