-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45055/#review124479
-----------------------------------------------------------



We should be able to just move the styles into the `head` section and leave the 
scripts where they are?

My understanding of the "state of the art" (such as it is) with regards to 
script loading, is that putting them in the correct order, at the end of the 
body, is still the best practive (see the of "Enough! How should I load 
scripts?" section of 
http://www.html5rocks.com/en/tutorials/speed/script-loading/ for the tl;dr, or 
read the whole thing for the sorry state of affairs).

- Joshua Cohen


On March 18, 2016, 10:14 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45055/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 10:14 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Refreshing a subpage of /scheduler in Chrome temporarily resize the Aurora
> logo. This seems to be due to us loading all scripts and styles in the <body>
> after first rending the logo.
> 
> By loading all scripts in the header using the `defer` attribute, scripts are
> only executed after the entire document has been loaded. They are executed in
> order.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/scheduler/assets/scheduler/index.html 
> 383ca43dfc14448b67181e9d94dd805ac1bbfaa7 
> 
> Diff: https://reviews.apache.org/r/45055/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Reply via email to