----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45112/#review124821 -----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java (line 254) <https://reviews.apache.org/r/45112/#comment187508> Shouldn't that rather be formulated as container != `MESOS`? As the Image field will only work together with the Mesos containerizer. - Stephan Erb On March 22, 2016, 4:49 p.m., Joshua Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45112/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 4:49 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-1635 > https://issues.apache.org/jira/browse/AURORA-1635 > > > Repository: aurora > > > Description > ------- > > Add support for storing and fetching images as properties of task configs. > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > d4b8904031e6671a8083cac9b82d934377797fe2 > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > b3b8ccf868c2a2f18f720a837e90d763072dd3eb > src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java > 364026a8ef2b47cf1beafa3990691d3375516fe6 > src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java > 12ca16b79a062d9ea15c206ef963fb077ad7ad98 > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbImage.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java > eb848add00fba6d3571657bb9080be0599b2756a > > src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml > fd272ccf9b1cfccd9198d1e5e0db37d23f546afa > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql > be60c3be0cd51d06ba0ca7f56384281ee71d8c55 > > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java > 1a520b3cb035a9afc25406d2f313c9f861eee4d6 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java > c316e497a34a45c7ada2ca83a1115e826c0f572f > > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java > e56fed2e6c0cdb47737cf1a9b637c44c5e5b9815 > > src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java > 08530397ff75081bde6f07f9d53317b5486e0da4 > > Diff: https://reviews.apache.org/r/45112/diff/ > > > Testing > ------- > > ./gradlew build -Pq > > ran e2e tests. > > > Thanks, > > Joshua Cohen > >
