> On March 21, 2016, 8:48 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
> >  line 345
> > <https://reviews.apache.org/r/45135/diff/1/?file=1309594#file1309594line345>
> >
> >     I think we should be consistent and return a message like "No active 
> > cron schedule found" in this case similar the `killTasks` behavior.

+1


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45135/#review124726
-----------------------------------------------------------


On March 21, 2016, 5:19 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45135/
> -----------------------------------------------------------
> 
> (Updated March 21, 2016, 5:19 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1645
>     https://issues.apache.org/jira/browse/AURORA-1645
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This allows clients to be more declarative rather than imperative
> when expressing that the given job should not be scheduled.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 6e9364e34db6dbb270468db3ff333b956c6bf9f3 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  d217faf44ab3d6132db3b3c4eed67effd03fb6fa 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  c774ac0f0e2fdda7fe9b64fd9181f107b3fd9eca 
> 
> Diff: https://reviews.apache.org/r/45135/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Reply via email to