-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45042/#review124841
-----------------------------------------------------------



Master (335cf88) is red with this patch.
  ./build-support/jenkins/build.sh

                           mock_dump_runner_pex.return_value = Mock()
                           mock_options = Mock()
                           mock_options.execute_as_user = False
                           mock_options.nosetuid = False
                           with patch(
                               
'apache.aurora.executor.bin.thermos_executor_main.dump_runner_pex',
                               return_value=mock_dump_runner_pex):
                             with patch(
                                 
'apache.aurora.executor.bin.thermos_executor_main.DefaultThermosTaskRunnerProvider',
                                 return_value=mock_runner_provider) as 
mock_provider:
                         
                               expected_path = 
os.path.join(os.path.abspath('.'), MesosPathDetector.DEFAULT_SANDBOX_PATH)
                     >         thermos_executor = 
initialize(mock_options)
                     
                     
src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py:44:
 
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     
.pants.d/python-setup/chroots/3acd03dbb81b37f2a14a0799a3e0bd882c60c91a/apache/aurora/executor/bin/thermos_executor_main.py:204:
 in initialize
                         default_acl = 
make_default_acl(options.announcer_zookeeper_auth_config)
                     
.pants.d/python-setup/chroots/3acd03dbb81b37f2a14a0799a3e0bd882c60c91a/apache/aurora/executor/common/announcer.py:107:
 in make_default_acl
                         auth_config = parse_config(zk_auth_config)
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     
                     config_file = <Mock 
name='mock.announcer_zookeeper_auth_config' id='140044375200848'>
                     
                         def parse_config(config_file):
                           try:
                     >       with open(config_file) as fp:
                     E       TypeError: coercing to Unicode: need 
string or buffer, Mock found
                     
                     
.pants.d/python-setup/chroots/3acd03dbb81b37f2a14a0799a3e0bd882c60c91a/apache/aurora/executor/common/announcer.py:92:
 TypeError
                     -------------- Captured stderr call --------------
                     WARNING:root:Please remove the deprecated and no-op 
--announcer-enable flag in scheduler config!
                      generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
                      1 failed, 667 passed, 5 skipped, 1 warnings in 
438.62 seconds 
                     
FAILURE


17:31:23 08:55   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 22, 2016, 5:02 p.m., Kunal Thakar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45042/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 5:02 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add ACL support for announcer
> https://issues.apache.org/jira/browse/AURORA-1643
> 
> Adding support for service discovery ZK authentication. ZK authentication 
> secrets should be stored in a file as json (as follows):
> ```json
> {
>   "scheme": "<scheme>",
>   "credential": "<credential>",
>       "permissions": {
>         "read": <bool>,
>         "write": <bool>,
>         "create": <bool>,
>         "delete": <bool>,
>         "admin": <bool>,
>         "all": <bool>
>       }
> }
> ```
> 
> 
> Diffs
> -----
> 
>   docs/security.md 32bea426fbceec83187e851a5db11e82df55e962 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> 6634506108c346f8c23b2da7cc8d20d09d07d590 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 79a9cfb6ac3a8444f09fb3658e6e859e06941ba4 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> 142b58d5e577c9f4b8e2ae8473cffdea94eba21f 
> 
> Diff: https://reviews.apache.org/r/45042/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kunal Thakar
> 
>

Reply via email to