-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45115/
-----------------------------------------------------------
(Updated March 22, 2016, 1:06 p.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Changes
-------
Added e2e test to ensure that final processes are executed on completion of
regular processes in the presence of long-running ephemeral_daemon processes.
Bugs: AURORA-1642
https://issues.apache.org/jira/browse/AURORA-1642
Repository: aurora
Description
-------
AURORA-1642: Fix for broken finalization in Thermos runner.
Diffs (updated)
-----
src/main/python/apache/thermos/core/process.py
f147af7d0e84309691c135c8057a597379fa83e7
src/test/python/apache/thermos/core/test_process.py
c339c91eb24616c8d640877ef088f659523d2bf5
src/test/sh/org/apache/aurora/e2e/ephemeral_daemon_with_final.aurora
PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
b469f9bbbdfbf98df947832411bd0cdce97affdc
Diff: https://reviews.apache.org/r/45115/diff/
Testing
-------
# End to end tests
```
$ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
...
*** OK (All tests passed) ***
```
# Python unit tests
```
$ ./pants test src/test/python::
...
663 passed, 5 skipped, 1 warnings in 180.34 seconds
```
# Also tested using a test job in vagrant to ensure that "final" processes are
executed as expected using this job definition:
https://gist.github.com/adeshmukh/697d013dec64498a3942
Thanks,
Amol Deshmukh
