-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45167/#review124889
-----------------------------------------------------------



Looks good! A few notes regarding related sections, even though not completely 
correleated with your change.


docs/installing.md (line 154)
<https://reviews.apache.org/r/45167/#comment187582>

    That whole section seems outdate.



docs/installing.md (line 246)
<https://reviews.apache.org/r/45167/#comment187584>

    Maybe it is more straight forward here to tell where that value is 
configured. Because if it is wrong, the user will have a hard time digging 
where and how our Thermos observer is configured.



docs/installing.md (line 278)
<https://reviews.apache.org/r/45167/#comment187585>

    Wow, I am surprised. Is that actually working?



docs/installing.md (line 312)
<https://reviews.apache.org/r/45167/#comment187586>

    I believe everything after the "-" is optional and does not need to be 
included.


- Stephan Erb


On March 22, 2016, 6:48 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45167/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 6:48 p.m.)
> 
> 
> Review request for Aurora, Benjamin Rice and Stephan Erb.
> 
> 
> Bugs: AURORA-1647
>     https://issues.apache.org/jira/browse/AURORA-1647
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This set of fixes eliminates the experimental rpm warnings and updates
> the rpm instructions to use the officially released packages.  The deb
> instructions are updated as well, in particular to take advantage of the
> mesosphere deb repository and with movement of special dep installations
> to the appropriate sections requiring them.
> 
> This fix RB does not address the new Debian Jessie debs, instead
> focusing on getting the existing instructions corrected.
> 
>  docs/installing.md | 101 +++++++++++++++++++++++++++-----------------------
>  1 file changed, 55 insertions(+), 46 deletions(-)
> 
> 
> Diffs
> -----
> 
>   docs/installing.md c3abb332a4a46e62367a39cf73d70f2185657b5a 
> 
> Diff: https://reviews.apache.org/r/45167/diff/
> 
> 
> Testing
> -------
> 
> These changes are rendered here:
>   
> https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1647/docs/installing.md
> 
> I ran through the instructions in full in fresh Vagrant vms and was able
> to launch sample jobs (used aurora-packaging test jobs with cpu droppped to
> `0.5` and s/Service/Job/) and exercise the full UI chain to inspect the
> successful one-shot job and its sandbox & logs.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Reply via email to