----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45330/#review125390 -----------------------------------------------------------
Ship it! Change, LGTM. Mind running the benchmarks in `TaskStoreBenchmarks` to validate that there is no crazy performance difference from this change? I know this change seems innocent but I recall `<constructor>` being much slower than expected. - Zameer Manji On March 24, 2016, 9:43 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45330/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 9:43 p.m.) > > > Review request for Aurora, John Sirois and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > I realized that on _insert_, we can iterate over `Map`s just fine (without > the conversion to `List<Pair<?, ?>`, which allows us to remove some code. > Unfortunately i do not yet know of an approach to remove the workaround when > querying. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java > 078dd8b63fdca192c735f9097edd030ee315a021 > src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java > 364026a8ef2b47cf1beafa3990691d3375516fe6 > src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java > 12ca16b79a062d9ea15c206ef963fb077ad7ad98 > src/main/java/org/apache/aurora/scheduler/storage/db/TaskMapper.java > 4bf40047e105389ac7139edc449857889d390106 > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssginedPort.java > fdfff774e13f3e5f5e2c08f4692bc61427f2cbaf > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssignedTask.java > cbc6a0c6085287f8065f182c24f79e47812af498 > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java > eb848add00fba6d3571657bb9080be0599b2756a > src/main/java/org/apache/aurora/scheduler/storage/db/views/Pairs.java > 922578f0e545de67cfd26a601af29f00882a2a09 > > src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml > fd272ccf9b1cfccd9198d1e5e0db37d23f546afa > src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml > 684614ffc42dd6778c7675a6c2f81cb72c106c0e > > Diff: https://reviews.apache.org/r/45330/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >