-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45366/#review125585
-----------------------------------------------------------



@ReviewBot retry

- John Sirois


On March 27, 2016, 4:39 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45366/
> -----------------------------------------------------------
> 
> (Updated March 27, 2016, 4:39 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1650
>     https://issues.apache.org/jira/browse/AURORA-1650
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> These methods always returned `true`, which was misleading.  Eliminate
> these query methods and force users to consult the collection for
> emptiness to make intentions more clear.
> 
>  
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  | 3 +--
>  src/main/java/org/apache/aurora/scheduler/http/Mname.java                    
>      | 4 +---
>  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java        
>      | 4 +---
>  
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java
>     | 2 +-
>  src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java   
>      | 1 -
>  src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py           
>      | 2 +-
>  6 files changed, 5 insertions(+), 11 deletions(-)
> 
> 
> Diffs
> -----
> 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  b3b8ccf868c2a2f18f720a837e90d763072dd3eb 
>   src/main/java/org/apache/aurora/scheduler/http/Mname.java 
> 807a1989473f1a933790e5837d804941419007a3 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 20cbd419dcb988f2c7ba72c8acbe6fee90d02248 
>   
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java
>  4b0ef81e5dd2723291a9810980246c6c3e7924f5 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 
> 69010985aa066ebb6686f256a734d77e008ccd1a 
>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
> e9e9368328992cb8cc26eb22d86aa244d5fa9250 
> 
> Diff: https://reviews.apache.org/r/45366/diff/
> 
> 
> Testing
> -------
> 
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Reply via email to