Re: Review Request 45372: Remove sleep and address flaky health check test.

[Aurora ReviewBot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45372/#review125592
-----------------------------------------------------------



Master (b352e8b) is red with this patch.
  ./build-support/jenkins/build.sh

                           proxy_driver = ProxyDriver()
                           with temporary_dir() as checkpoint_root:
                             te = AuroraExecutor(
                     >           
runner_provider=make_provider(checkpoint_root),
                                 
sandbox_provider=DefaultTestSandboxProvider())
                     
                     
src/test/python/apache/aurora/executor/test_thermos_executor.py:580: 
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     
src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in 
make_provider
                         pex_location=thermos_runner_path(),
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     
                     build = True
                     
                         def thermos_runner_path(build=True):
                           if not build:
                             return getattr(thermos_runner_path, 'value', 
None)
                         
                           if not hasattr(thermos_runner_path, 'value'):
                             pex_dir = safe_mkdtemp()
                     >       assert subprocess.call(["./pants", 
"--pants-distdir=%s" % pex_dir, "binary",
                               
"src/main/python/apache/thermos/runner:thermos_runner"]) == 0
                     E       assert 1 == 0
                     E        +  where 1 = <function call at 
0x7fc71ed8a938>(['./pants', '--pants-distdir=/tmp/user/20000/tmpUYybxs', 
'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])
                     E        +    where <function call at 
0x7fc71ed8a938> = subprocess.call
                     
                     
src/test/python/apache/aurora/executor/test_thermos_executor.py:185: 
AssertionError
                     -------------- Captured stderr call --------------
                     Traceback (most recent call last):
                       File 
"/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.75/bin/pants", 
line 7, in <module>
                         from pants.bin.pants_exe import main
                     ImportError: No module named pants.bin.pants_exe
                      generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
                      18 failed, 638 passed, 5 skipped, 1 warnings, 8 
error in 294.75 seconds 
                     
FAILURE


04:23:23 07:21   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 28, 2016, 3:41 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45372/
> -----------------------------------------------------------
> 
> (Updated March 28, 2016, 3:41 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Posting this patch to at least start a conversation on fixing this test; i've 
> noticed it flaking pretty frequently lately.  Here i take the quick and dirty 
> approach of removing the sleep and glossing over the `total_latency_secs` 
> value.
> 
> 
> Diffs
> -----
> 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> 19c4f76347e34374c29974c182d1f4c118bcb18d 
> 
> Diff: https://reviews.apache.org/r/45372/diff/
> 
> 
> Testing
> -------
> 
> None yet
> 
> 
> Thanks,
> 
> Bill Farner
> 
>