-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45042/
-----------------------------------------------------------

(Updated March 28, 2016, 10:51 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
-------

Thanks for the feedback, auth_data is indeed a required piece of information 
that is needed before setting ACLs. I have updated the config file structure as 
follows to accomodate authentication credentials in addition to the ACL objects:
```json
{
  "auth": [
    {
      "scheme": "<scheme>",
      "credential": "<plain_credential>"
    }
  ],
  "acls": [
    {
      "scheme": "<scheme>",
      "credential": "<encrypted_credential>",
      "permissions": {
        "read": <bool>,
        "write": <bool>,
        "create": <bool>,
        "delete": <bool>,
        "admin": <bool>,
        "all": <bool>
      }
    }
  ]
}
```


Repository: aurora


Description
-------

Add ACL support for announcer
https://issues.apache.org/jira/browse/AURORA-1643

Adding support for service discovery ZK authentication. ZK authentication 
secrets should be stored in a file as json (as follows):
```json
{
  "scheme": "<scheme>",
  "credential": "<credential>",
        "permissions": {
          "read": <bool>,
          "write": <bool>,
          "create": <bool>,
          "delete": <bool>,
          "admin": <bool>,
          "all": <bool>
        }
}
```


Diffs (updated)
-----

  RELEASE-NOTES.md 6e9364e34db6dbb270468db3ff333b956c6bf9f3 
  docs/security.md 32bea426fbceec83187e851a5db11e82df55e962 
  examples/vagrant/announcer-auth.json PRE-CREATION 
  examples/vagrant/upstart/aurora-scheduler-announcer-auth.conf PRE-CREATION 
  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
6634506108c346f8c23b2da7cc8d20d09d07d590 
  src/main/python/apache/aurora/executor/common/announcer.py 
79a9cfb6ac3a8444f09fb3658e6e859e06941ba4 
  
src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py 
e9f7851292aef3a36da5da9b0fc333a7e7750cf3 
  src/test/python/apache/aurora/executor/common/test_announcer.py 
142b58d5e577c9f4b8e2ae8473cffdea94eba21f 
  src/test/sh/org/apache/aurora/e2e/test_announcer_auth_end_to_end.sh 
PRE-CREATION 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
b469f9bbbdfbf98df947832411bd0cdce97affdc 
  src/test/sh/org/apache/aurora/e2e/validate_serverset.py 
fca1137bd2e7b1306a03dc2a54d2ef15b59af6a8 

Diff: https://reviews.apache.org/r/45042/diff/


Testing
-------


Thanks,

Kunal Thakar

Reply via email to