> On March 29, 2016, 12:03 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java,
> >  line 112
> > <https://reviews.apache.org/r/45396/diff/1/?file=1316952#file1316952line112>
> >
> >     Given that this is a static method, it should be pretty easy to test, 
> > would you mind adding a test case for this behavior (probably requires 
> > refactoring the method to take the arg values as parameters, rather than 
> > referencing them directly).

Sure, will do.


- George


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45396/#review125779
-----------------------------------------------------------


On March 28, 2016, 6:21 p.m., George Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45396/
> -----------------------------------------------------------
> 
> (Updated March 28, 2016, 6:21 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Steve Niemitz, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> In instances where the root filesystem is read-only, it is desirable to
> have the executor/runner extract themselves into the sandbox.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 34f28a165aae4ae24fa95ef19b4972e088fd63a0 
>   docs/deploying-aurora-scheduler.md 03bfdbab927c924486b04c42df2ad236c0f414a0 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
>  949c299bdbc54f976db994266fb97f3099256f13 
> 
> Diff: https://reviews.apache.org/r/45396/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> George Sirois
> 
>

Reply via email to