----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45457/#review125972 -----------------------------------------------------------
Master (ec29ac1) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On March 29, 2016, 11:01 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45457/ > ----------------------------------------------------------- > > (Updated March 29, 2016, 11:01 p.m.) > > > Review request for Aurora, John Sirois and Zameer Manji. > > > Bugs: AURORA-1652 > https://issues.apache.org/jira/browse/AURORA-1652 > > > Repository: aurora > > > Description > ------- > > Short of surveying call sites, i don't know the impact of this change. > However, my sense is that it's still better to fail fast than produce > incorrect results (due to the recent change in semantics of filtering by an > empty iterable). > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/base/Query.java > c76b365f43eb6a3b9b0b63a879b43eb04dcd8fac > > Diff: https://reviews.apache.org/r/45457/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
