-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45511/#review126221
-----------------------------------------------------------



Master (193f17e) is red with this patch.
  ./build-support/jenkins/build.sh

:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:22:
 error: 'org.apache.aurora.scheduler.http.LeaderRedirect.LeaderStatus' should 
be separated from previous imports.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:25:
 error: Line is longer than 100 characters (found 163).
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:30:
 error: 'member def modifier' have incorrect indentation level 4, expected 
level should be 2.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:32:
 error: 'ctor def modifier' have incorrect indentation level 4, expected level 
should be 2.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:34:
 error: 'ctor def' child have incorrect indentation level 8, expected level 
should be 4.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:35:
 error: 'ctor def rcurly' have incorrect indentation level 4, expected level 
should be 2.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:39:
 error: Line is longer than 100 characters (found 111).
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:44:
 error: 'method def modifier' have incorrect indentation level 4, expected 
level should be 2.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:47:
 error: 'member def type' have incorrect indentation level 8, expected level 
should be 4.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:47:
 error: 'method def' child have incorrect indentation level 8, expected level 
should be 4.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:49:
 error: 'if' have incorrect indentation level 8, expected level should be 4.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:49:11:
 error: 'if' is not followed by whitespace.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:50:
 error: 'if' child have incorrect indentation level 12, expected level should 
be 6.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:51:
 error: 'if rcurly' have incorrect indentation level 8, expected level should 
be 4.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:51:9:
 error: '}' at column 9 should be on the same line as the next part of a 
multi-block statement.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:52:
 error: 'else' have incorrect indentation level 8, expected level should be 4.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:52:16:
 error: 'if' is not followed by whitespace.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:53:
 error: 'if' child have incorrect indentation level 12, expected level should 
be 6.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:54:
 error: 'if rcurly' have incorrect indentation level 8, expected level should 
be 4.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:54:9:
 error: '}' at column 9 should be on the same line as the next part of a 
multi-block statement.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:55:
 error: 'else' have incorrect indentation level 8, expected level should be 4.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:56:
 error: 'else' child have incorrect indentation level 12, expected level should 
be 6.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:57:
 error: 'else rcurly' have incorrect indentation level 8, expected level should 
be 4.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java:58:
 error: 'method def rcurly' have incorrect indentation level 4, expected level 
should be 2.
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 35.849 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 30, 2016, 11:19 p.m., Ashwin Murthy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45511/
> -----------------------------------------------------------
> 
> (Updated March 30, 2016, 11:19 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1493: create ELB-friendly endpoint to detect leading scheduler. The 
> fix is to add a new endpoint - "/leaderhealth" which returns http status code 
> 200 (OK) if the instance is the leader. If the instance is not the leader but 
> a leading exists, returns 500 (Internal server error). If there is no leader 
> at all, returns 503 (Service unavailable)
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderHealthTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45511/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test
> 
> 
> Thanks,
> 
> Ashwin Murthy
> 
>

Reply via email to