> On March 30, 2016, 11:15 p.m., Aurora ReviewBot wrote:
> > Master (193f17e) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> >                            
> > self._clock.converge(threads=[hct.threaded_health_checker])
> >                            
> > self._clock.assert_waiting(hct.threaded_health_checker, amount=1)
> >                          
> >                            assert hct._total_latency == 0
> >                            assert 
> > hct.metrics.sample()['total_latency_secs'] == 0
> >                          
> >                            # start the health check (during health 
> > check it is still 0)
> >                            epsilon = 0.001
> >                            self._clock.tick(1.0 + epsilon)
> >                            
> > self._clock.converge(threads=[hct.threaded_health_checker])
> >                            
> > self._clock.assert_waiting(hct.threaded_health_checker, amount=0.5)
> >                            assert hct._total_latency == 0
> >                            assert 
> > hct.metrics.sample()['total_latency_secs'] == 0
> >                            assert hct.metrics.sample()['checks'] == 
> > 0
> >                          
> >                            # finish the health check
> >                            self._clock.tick(0.5 + epsilon)
> >                            
> > self._clock.converge(threads=[hct.threaded_health_checker])
> >                            
> > self._clock.assert_waiting(hct.threaded_health_checker, amount=1)  # 
> > interval_secs
> >                      >     assert hct._total_latency == 0.5
> >                      E     AssertionError: assert 
> > 0.5009999999999999 == 0.5
> >                      E      +  where 0.5009999999999999 = 
> > <apache.aurora.executor.common.health_checker.HealthChecker object at 
> > 0x7f2a4f271c50>._total_latency
> >                      
> >                      
> > src/test/python/apache/aurora/executor/common/test_health_checker.py:174: 
> > AssertionError
> >                      -------------- Captured stderr call --------------
> >                      [<twitter.common.testing.clock.ThreadedClock object at 
> > 0x7f2a4f271f10>] Time now: 0.0
> >                      [<twitter.common.testing.clock.ThreadedClock object at 
> > 0x7f2a4f271f10>] Time now: 0.0
> >                      [<twitter.common.testing.clock.ThreadedClock object at 
> > 0x7f2a4f271f10>] Time now: 1.0
> >                      [<twitter.common.testing.clock.ThreadedClock object at 
> > 0x7f2a4f271f10>] Time now: 1.001
> >                      [<twitter.common.testing.clock.ThreadedClock object at 
> > 0x7f2a4f271f10>] Time now: 1.001
> >                      [<twitter.common.testing.clock.ThreadedClock object at 
> > 0x7f2a4f271f10>] Time now: 1.501
> >                      [<twitter.common.testing.clock.ThreadedClock object at 
> > 0x7f2a4f271f10>] Time now: 1.502
> >                       generated xml file: 
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
> >  
> >                       2 failed, 667 passed, 5 skipped, 1 warnings 
> > in 209.54 seconds 
> >                      
> > FAILURE
> > 
> > 
> > 06:07:16 04:23   [complete]
> >                FAILURE
> > 
> > 
> > I will refresh this build result if you post a review containing 
> > "@ReviewBot retry"

@ReviewBot retry


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45521/#review126276
-----------------------------------------------------------


On March 30, 2016, 10:55 p.m., Benjamin Staffin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45521/
> -----------------------------------------------------------
> 
> (Updated March 30, 2016, 10:55 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-319
>     https://issues.apache.org/jira/browse/AURORA-319
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This should be done in the scheduler, if anywhere.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/config.py 
> 2fc12559016d406c347adb416a5166cca31c961e 
> 
> Diff: https://reviews.apache.org/r/45521/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Staffin
> 
>

Reply via email to