-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45521/#review126298
-----------------------------------------------------------



Couple of thoughts on this:

* Cool feature! We'd probably use that as well
* I believe it does still make sense to have a scheduler-side validation. 
Otherwise this could lead to total chaos
* Whatever we do, docs have to be kept in sync :-): 
https://github.com/apache/aurora/blob/master/docs/features/multitenancy.md#job-namespaces
 Doing a quick search however indicates that there are atleast 3 other places 
that also list the currently hard coded environment names

- Stephan Erb


On March 31, 2016, 7:55 a.m., Benjamin Staffin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45521/
> -----------------------------------------------------------
> 
> (Updated March 31, 2016, 7:55 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-319
>     https://issues.apache.org/jira/browse/AURORA-319
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This should be done in the scheduler, if anywhere.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/config.py 
> 2fc12559016d406c347adb416a5166cca31c961e 
> 
> Diff: https://reviews.apache.org/r/45521/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Staffin
> 
>

Reply via email to