-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45511/#review126573
-----------------------------------------------------------


Fix it, then Ship it!




Looks good. Minor nitpicks below.


RELEASE-NOTES.md (line 6)
<https://reviews.apache.org/r/45511/#comment189595>

    Please stick to max 100 cols.



RELEASE-NOTES.md (line 8)
<https://reviews.apache.org/r/45511/#comment189594>

    Please leave this line at the top of our changelog, as it tends to be the 
most important entry.



docs/operations/endpoints.md (line 1)
<https://reviews.apache.org/r/45511/#comment189596>

    Seeing this spelled out, it will probably be more like a (compelete) 
reference rather than a guide for operators.
    
    Would you mind moving this to `reference/scheduler-endpoints.md`?



src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java (line 36)
<https://reviews.apache.org/r/45511/#comment189593>

    That's cool. Thanks :-)


- Stephan Erb


On April 1, 2016, 8:08 a.m., Ashwin Murthy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45511/
> -----------------------------------------------------------
> 
> (Updated April 1, 2016, 8:08 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1493: create ELB-friendly endpoint to detect leading scheduler. The 
> fix is to add a new endpoint - "/leaderhealth" which returns http status code 
> 200 (OK) if the instance is the leader. If the instance is not the leader but 
> a leading exists, returns 500 (Internal server error). If there is no leader 
> at all, returns 503 (Service unavailable)
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 6fc3afeb5a9e2f2c2ba944fbc6d611d3494eb779 
>   docs/operations/endpoints.md PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderHealthTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45511/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test
> 
> 
> Thanks,
> 
> Ashwin Murthy
> 
>

Reply via email to