> On April 1, 2016, 7:48 p.m., Bill Farner wrote:
> > Biggest issue - the servlet isn't actually wired in and therefore the 
> > scheduler does not respond to `/leaderhealth`.  I suggest we add a check in 
> > the end-to-end tests to verify this behavior and make sure wiring is 
> > correct.
> > 
> > As for behavior, i'm still not fond of returning 500 for an expected phase 
> > of the scheduler lifecycle (e.g. while leadership is changing).  Counters 
> > for 500 responses should be reserved for things that people can alert on 
> > and debug.  How about 502 (bad gateway) instead?
> > 
> > I've gone ahead and addressed my outstanding comments 
> > [here](https://github.com/wfarner/aurora/commit/a769a9de3361611ef75398475f511ccb96a9d2d3),
> >  feel free to pull that commit and apply the changes you agree with.

Oh the jettyservermodule update is a big miss. I knew i had to make this 
earlier but forgot to get to it. Thanks for the catch and I will add the e2e 
test for the same reason.


- Ashwin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45511/#review126623
-----------------------------------------------------------


On April 1, 2016, 2:21 p.m., Ashwin Murthy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45511/
> -----------------------------------------------------------
> 
> (Updated April 1, 2016, 2:21 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1493: create ELB-friendly endpoint to detect leading scheduler. The 
> fix is to add a new endpoint - "/leaderhealth" which returns http status code 
> 200 (OK) if the instance is the leader. If the instance is not the leader but 
> a leading exists, returns 500 (Internal server error). If there is no leader 
> at all, returns 503 (Service unavailable)
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 6fc3afeb5a9e2f2c2ba944fbc6d611d3494eb779 
>   docs/reference/scheduler-endpoints.md PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderHealthTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45511/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test
> 
> 
> Thanks,
> 
> Ashwin Murthy
> 
>

Reply via email to