-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45511/#review126857
-----------------------------------------------------------


Fix it, then Ship it!




LGTM after some very minor tweaks.  Thanks!


RELEASE-NOTES.md (line 8)
<https://reviews.apache.org/r/45511/#comment189944>

    remove the extra hyphen, otherwise thie results in a separate bullet.



docs/reference/scheduler-endpoints.md (line 2)
<https://reviews.apache.org/r/45511/#comment189945>

    Please remove the TODO.  While not a lie, the ticket is the best place to 
track the work.



src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java (line 42)
<https://reviews.apache.org/r/45511/#comment189947>

    Remove "This is added as part of AURORA-1493 and", as it becomes irrelevant 
~immediately after commit.


- Bill Farner


On April 1, 2016, 10:24 p.m., Ashwin Murthy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45511/
> -----------------------------------------------------------
> 
> (Updated April 1, 2016, 10:24 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1493: create ELB-friendly endpoint to detect leading scheduler. The 
> fix is to add a new endpoint - "/leaderhealth" which returns http status code 
> 200 (OK) if the instance is the leader. If the instance is not the leader but 
> a leading exists, returns 500 (Internal server error). If there is no leader 
> at all, returns 503 (Service unavailable)
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 6fc3afeb5a9e2f2c2ba944fbc6d611d3494eb779 
>   docs/reference/scheduler-endpoints.md PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> df649ff4ffdc741afdbc4850c2dbf98bd3e218f1 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java 
> PRE-CREATION 
>   src/main/resources/scheduler/assets/index.html 
> 861d5518890182737c6e545d6c409004c23cd18d 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderHealthTest.java 
> PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> e1c12bbd4382c31e576439f6693d82d5661029b9 
> 
> Diff: https://reviews.apache.org/r/45511/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test
> 
> 
> Thanks,
> 
> Ashwin Murthy
> 
>

Reply via email to