-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45723/
-----------------------------------------------------------

Review request for Aurora and Bill Farner.


Bugs: AURORA-1468
    https://issues.apache.org/jira/browse/AURORA-1468


Repository: aurora


Description
-------

This makes space for introducing an Apache Curator implementation.

 commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonService.java 
                                       | 133 
+++++++++++++++-----------------------------------
 
commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonServiceImpl.java
                                    | 122 
+++++++++++++++++++++++++++++++++++++++++++++
 
commons/src/test/java/org/apache/aurora/common/zookeeper/{SingletonServiceTest.java
 => SingletonServiceImplTest.java} |  11 ++---
 src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java              
                                       |  14 ++----
 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java               
                                       |   7 +--
 src/main/java/org/apache/aurora/scheduler/app/ServiceDiscoveryModule.java      
                                       |   5 +-
 src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java          
                                       |   2 +-
 7 files changed, 177 insertions(+), 117 deletions(-)


Diffs
-----

  
commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonService.java 
20accd20b80eed8a7ccf008ac1b5afc4c7ee7a88 
  
commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonServiceImpl.java
 PRE-CREATION 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceTest.java
 454ae226b2e52db18321eb95e7338a07231a1c0e 
  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
b15540c5e9733a57f42a6efb7bb017ebce64c15d 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
60b66e85f83edd3c18c97e3938816cb875249d4e 
  src/main/java/org/apache/aurora/scheduler/app/ServiceDiscoveryModule.java 
97977fd6173946e19a25aefcc6b5df478454f7a3 
  src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 
e225ae5ffd5f17f938fe42ebb604d8ea08010f9e 

Diff: https://reviews.apache.org/r/45723/diff/


Testing
-------

Locally green:
```
./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```


Thanks,

John Sirois

Reply via email to