> On April 5, 2016, 5:18 p.m., Maxim Khutornenko wrote:
> > src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java, 
> > line 179
> > <https://reviews.apache.org/r/45754/diff/1/?file=1326081#file1326081line179>
> >
> >     The number of these almost identical message tests grew up over time. 
> > Mind refactoring the common parts into a helper method instead?

Done, thanks for the nudge.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45754/#review127143
-----------------------------------------------------------


On April 5, 2016, 5:40 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45754/
> -----------------------------------------------------------
> 
> (Updated April 5, 2016, 5:40 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Use message provided by Mesos if present when tasks fail due to resource 
> limit violations.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 
> d4de225c7a96b26e493a3e77a2245ec132e06a08 
>   src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 
> 62ada33abcef977e722362904d671352e7f9947a 
> 
> Diff: https://reviews.apache.org/r/45754/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> See attached screenshot for the Mesos-provided message we'll show in the case.
> 
> 
> File Attachments
> ----------------
> 
> Exampled failed task
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/05/df35aa54-2ef3-4e3b-8c9a-d3fe9bd26f74__Screen_Shot_2016-04-05_at_11.54.01_AM.png
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Reply via email to