> On April 5, 2016, 5:50 p.m., Maxim Khutornenko wrote: > > src/test/sh/org/apache/aurora/e2e/http/http_example.aurora, line 21 > > <https://reviews.apache.org/r/45177/diff/6/?file=1326033#file1326033line21> > > > > Curious, what do changes in this file actually test?
I used this to trigger the multiple ports case and test what SRV records Mesos DNS uses. I can revert change to this file if people don't like it, but I figured a slightly more complex example wouldn't really hurt. > On April 5, 2016, 5:50 p.m., Maxim Khutornenko wrote: > > docs/features/service-discovery.md, line 31 > > <https://reviews.apache.org/r/45177/diff/6/?file=1326025#file1326025line31> > > > > Where is `twitterscheduler` part coming from in this example? This is the lower case of `CommandLineDriverSettingsModule.TWITTER_FRAMEWORK_NAME`. There is a TODO to allow this being reconfigured in Aurora, and I also filed an issue to Mesos DNS. I'll add some explanation. > On April 5, 2016, 5:50 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line > > 252 > > <https://reviews.apache.org/r/45177/diff/6/?file=1326030#file1326030line252> > > > > This should be moved above the previous line it belongs to. fixing - Zhitao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/#review127147 ----------------------------------------------------------- On April 5, 2016, 4:20 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45177/ > ----------------------------------------------------------- > > (Updated April 5, 2016, 4:20 p.m.) > > > Review request for Aurora, Kunal Thakar and Stephan Erb. > > > Bugs: AURORA-1629 > https://issues.apache.org/jira/browse/AURORA-1629 > > > Repository: aurora > > > Description > ------- > > This allows alternative service discovery methodologies to find tasks from > Aurora (e.g. mesos-dns), especially the dynamic port mapping. > > > Diffs > ----- > > RELEASE-NOTES.md 1df0345fac6ec6da92be15eb246c6957dea066bf > docs/features/service-discovery.md 858ca2a137db9c8fbce20e9b2b924447fe7a41ae > docs/reference/scheduler-configuration.md > e6c0bb60281d7c39c2aa235445ee4c1ef97464ba > examples/vagrant/upstart/aurora-scheduler.conf > d61801c0b7c9683434a548a26bed3c49bbb75927 > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java > add1270409b7e82578267a2c10cf2afe6e93e3de > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java > 7beea81a1e97f3f2fce215ff3e364919c3aebf6d > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java > 85c550bb5754154de5f639df4a0992d10cb70993 > src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java > 7110fbd78b1b4356acd40e5ab9c3379e5ac19df7 > > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java > 3a6048633efceec68b15d3c511237c0f1871a3fc > src/test/sh/org/apache/aurora/e2e/http/http_example.aurora > bb4fdec2fb2347635c6a7cc9e13133b4bf407771 > > Diff: https://reviews.apache.org/r/45177/diff/ > > > Testing > ------- > > 1. Added unit test; > 2. Use the vagrant environment to start the example in http_example.aurora, > and observe the following in master's state.json: > > ``` > curl 192.168.33.7:5050/state | jq . | less > .... > "tasks": [ > { > "discovery": { > "environment": "test", > "location": "devcluster", > "name": "http_example.test.vagrant", > "ports": { > "ports": [ > { > "name": "tcp", > "number": 31499, > "protocol": "TCP" > }, > { > "name": "http", > "number": 31529, > "protocol": "TCP" > } > ] > }, > "visibility": "CLUSTER" > }, > "executor_id": > "thermos-vagrant-test-http_example-1-e56d2834-3df3-4d6e-9399-4f5e80668703", > "framework_id": "66d5ac1b-9243-4ef3-8016-40f19d079f5d-0000", > "id": "vagrant-test-http_example-1-e56d2834-3df3-4d6e-9399-4f5e80668703", > "name": "vagrant/test/http_example", > "resources": { > "cpus": 0.4, > "disk": 64, > "mem": 32, > "ports": "[31499-31499, 31529-31529]" > }, > ... > .... > ``` > > > Thanks, > > Zhitao Li > >
