> On April 5, 2016, 7:06 a.m., Stephan Erb wrote: > > Just checking my understanding here: > > > > * the ticket reads like we first have to deprecate the locks, and then > > remove them. This review request seems to do this in one sitting. This is > > considered ok, because thrift will guarantee that an old client can always > > talk to the new scheduler that does not know about locks? > > * in how far is the `/locks` endpoint of the scheduler affected by this > > change? Will it still be around but only show information for on-going > > updates? > > Maxim Khutornenko wrote: > > the ticket reads like we first have to deprecate the locks, and then > remove them. This review request seems to do this in one sitting. > > I think it's ok to remove locks from thrift at this point as those were > effectively deprecated with client updater removal. Nothing should using > locks outside of the scheduler updater now. > > > in how far is the /locks endpoint of the scheduler affected by this > change? Will it still be around but only show information for on-going > updates? > > +1 to dropping /locks in this RB. We can always query outstanding locks > if needed via /h2console.
> +1 to dropping /locks in this RB Sounds good, i was on the fence on this anyhow. Please feel free to review in the meantime. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45718/#review127098 ----------------------------------------------------------- On April 4, 2016, 7:09 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45718/ > ----------------------------------------------------------- > > (Updated April 4, 2016, 7:09 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-1581 > https://issues.apache.org/jira/browse/AURORA-1581 > > > Repository: aurora > > > Description > ------- > > Remove lock-related constructs from the API. > > > Diffs > ----- > > RELEASE-NOTES.md 1df0345fac6ec6da92be15eb246c6957dea066bf > api/src/main/thrift/org/apache/aurora/gen/api.thrift > d4b8904031e6671a8083cac9b82d934377797fe2 > src/main/java/org/apache/aurora/scheduler/state/LockManager.java > 07de8fc0458cc3a2b2c49bc6962056ae5d5bbe9c > src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java > 6da6c69945fc42def801fd7dfa988304966349ba > src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java > 113af6a50cd5b36d3c640209b8fd222e6f866b61 > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 7eda474622388eb41695b65a4b349f416409a467 > > src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java > f2f69f9d7c34bbd24aaa7cb90455f32ebf9aa2cd > src/main/python/apache/aurora/admin/admin.py > 62a2302e58051670fd2a083ba87ccabe7dcf06c4 > src/main/python/apache/aurora/client/api/__init__.py > c5469bd89e57465e75a7c20c897a0bf9ce23c6f7 > src/main/python/apache/aurora/client/api/restarter.py > cd63311c0f1ca726a7145f1fdba8e772b6db6bbe > src/main/python/apache/aurora/client/hooks/hooked_api.py > 300071f4df4761e2e4e5de61e8bf5c9e44d895cb > src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java > f14d405ea3975d1045b62a77238b420dbb6cf3a8 > > src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java > dbec26ffb852c7804365467fbc00bb4efe19f2fb > > src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java > a70473074c3cf21e4395241217b6b3f694f346ea > src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java > a146e4005943a58e0d2df0773fc10e6489c12daa > src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java > be98f3862d537602c05275ba2466e2fdbf5e9b55 > > src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java > fcb5c2274d7636b5b94713e58d97de8d7cbd66a5 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > 85ca86cb333ec023c0cfd8379ac3308b83b6686f > src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java > 80e8ebea0c555b478810e9c9f35862dbb7e191a0 > src/test/python/apache/aurora/admin/test_admin.py > 22605ec8c28cf6d3b66c3dacc9634776d0afe8ff > src/test/python/apache/aurora/api_util.py > 4bb306fe577864c8611b6a34466b2189d903f103 > src/test/python/apache/aurora/client/api/test_api.py > c066ae7a05fbabaf7800d12459a743772366cbaa > src/test/python/apache/aurora/client/api/test_restarter.py > a75981c46048d5fb360e5af51026a776ec396592 > src/test/python/apache/aurora/client/api/test_scheduler_client.py > bed800d838d63ef76ec8f48d7c34cc0b165c26a2 > src/test/python/apache/aurora/client/cli/test_restart.py > fb4afcf7a3a395cc6400191183b54b9a68fa1964 > src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py > ca20ba5722c968583f31384326627936a39a1200 > > Diff: https://reviews.apache.org/r/45718/diff/ > > > Testing > ------- > > end-to-end tests are green > > > Thanks, > > Bill Farner > >
