-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45816/#review127429
-----------------------------------------------------------




src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java 
(line 84)
<https://reviews.apache.org/r/45816/#comment190721>

    How about making MigrationMapper an interface and sending here an anonymous 
no-op instance instead? I don't see any reason to run migration on restore from 
backup and we should simplify backup restore logic as much as possible.



src/main/java/org/apache/aurora/scheduler/storage/db/MigrationManager.java 
(line 40)
<https://reviews.apache.org/r/45816/#comment190722>

    Missing docs for public identifiers.



src/main/java/org/apache/aurora/scheduler/storage/db/MigrationManager.java 
(line 65)
<https://reviews.apache.org/r/45816/#comment190750>

    Just trying to understand the logic here. How does UpOperation() know what 
to apply? Does it use internal version table? Why can't we use the symmetric 
DownOperation()?



src/main/java/org/apache/aurora/scheduler/storage/db/MigrationManager.java 
(line 102)
<https://reviews.apache.org/r/45816/#comment190730>

    s/warn/info?



src/main/resources/org/apache/aurora/scheduler/storage/db/MigrationMapper.xml 
(line 20)
<https://reviews.apache.org/r/45816/#comment190727>

    This can be `sql`, right?



src/main/resources/org/apache/aurora/scheduler/storage/db/MigrationMapper.xml 
(line 25)
<https://reviews.apache.org/r/45816/#comment190724>

    I'd just use BLOB here.


- Maxim Khutornenko


On April 6, 2016, 7:27 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45816/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 7:27 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-1648
>     https://issues.apache.org/jira/browse/AURORA-1648
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add support for automated DB migrations and rollbacks when restoring from 
> dbScript stored in a snapshot.
> 
> 
> Diffs
> -----
> 
>   build.gradle ad5ec5c4afe4dd5c2189d0680692a7409f0417a9 
>   config/checkstyle/suppressions.xml 50a53e0d96cb365b2182b78769c1749b7e3558a9 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 60b66e85f83edd3c18c97e3938816cb875249d4e 
>   
> src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java
>  5c7d92f00ddda0a1f366ba1ca33b61829fa16ad9 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> baf460e987d0a6ba2810507695fe118b6b502f87 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java 
> 6f4e6710863a301238043edbb7bed1c7923a0720 
>   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationManager.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationMapper.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/MigrationChangelogEntry.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
> 6fee2510d044515e0704cf20ec0ba77231050ec4 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/MigrationMapper.xml 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/MigrationManagerIT.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/testmigration/V001_TestMigration.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java
>  d93eed925d289381cdac547ad1bce749c397a07f 
> 
> Diff: https://reviews.apache.org/r/45816/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> end to end tests.
> 
> Also manually verified that migrations and rollbacks are correctly performed 
> in vagrant.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Reply via email to