-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45829/#review127472
-----------------------------------------------------------


Ship it!




Ship It!

- Bill Farner


On April 6, 2016, 12:41 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45829/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 12:41 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1468
>     https://issues.apache.org/jira/browse/AURORA-1468
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This exposes the standard `ServerSet` `ServiceInstance` encoding to the
> `ServerSet` interface for conforming implementations to leverage.
> 
>  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java      
>    |  90 +++++++++++++++++++++++++++++++++++++++
>  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java  
>    | 114 +-------------------------------------------------
>  
> commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java
>  |  49 ----------------------
>  commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetTest.java  
>    |  78 ++++++++++++++++++++++++++++++++++
>  commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetsTest.java 
>    |   7 +---
>  5 files changed, 172 insertions(+), 166 deletions(-)
> 
> 
> Diffs
> -----
> 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java 
> 6e3208384149d34a6a1f0de86e8346be227efe69 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 
> 8b385b8ed07a109ee357d092f8919582035dc7cb 
>   
> commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java
>  37be70b7066d5a57f342e1f77d8269533d715406 
>   commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetTest.java 
> PRE-CREATION 
>   
> commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetsTest.java 
> 85b89d560fb3a01f0dd9eea6e0ce521c7adbc247 
> 
> Diff: https://reviews.apache.org/r/45829/diff/
> 
> 
> Testing
> -------
> 
> Locally green:
> ```
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Reply via email to