-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45850/
-----------------------------------------------------------

Review request for Aurora and Bill Farner.


Bugs: AURORA-1468
    https://issues.apache.org/jira/browse/AURORA-1468


Repository: aurora


Description
-------

This will be the home for the Curator implementations.

In the process, lift the `ServerSetMonitor` to a top-level class and add
a test. Also tighten up the `ServiceDiscoveryModule` and make
requirements and exports clear.

 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java               
          |   1 +
 
src/main/java/org/apache/aurora/scheduler/discovery/CommonsServerGroupMonitor.java
       |  59 ++++++++++++++++++++++
 src/main/java/org/apache/aurora/scheduler/{app => 
discovery}/ServiceDiscoveryModule.java |  61 +++++++---------------
 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java                 
          |   1 +
 
src/test/java/org/apache/aurora/scheduler/discovery/CommonsServerGroupMonitorTest.java
   | 137 ++++++++++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 216 insertions(+), 43 deletions(-)


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
11f6ad14eb334ce3e6390ca5754add1c0998d64e 
  src/main/java/org/apache/aurora/scheduler/app/ServiceDiscoveryModule.java 
73695cd125078f02737762c25abe8639066b4948 
  
src/main/java/org/apache/aurora/scheduler/discovery/CommonsServerGroupMonitor.java
 PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
5b7775005eb813493de3cb79ca3415c196d806c5 
  
src/test/java/org/apache/aurora/scheduler/discovery/CommonsServerGroupMonitorTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/45850/diff/


Testing
-------

Locally green:
```
./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```


Thanks,

John Sirois

Reply via email to